Add binary request example #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to play around with this some. Track 1 didn't have a fully asynchronous answer either. I'm thinking the answer is to convert from a Basically, it'd go: let file_stream = FileStream::new(tokio::fs::File::open("data.bin")?);
let body: Body = file_stream.into();
client.put_data(&ctx, body, None).await?; |
Also refactors `FileStream` from `azure_core` to `typespec_client_core`, plus some trait implementations on necessary request structures to make it all work.
heaths
force-pushed
the
binary-request
branch
from
e20d069
to
6b51460
Compare
heaths
requested review from
JeffreyRichter,
LarryOsterman and
ronniegeraghty
as code owners
heaths
commented
Oct 23, 2024
sdk/typespec/typespec_client_core/examples/binary_data_request.rs
Outdated
Show resolved
Hide resolved
heaths
commented
Oct 24, 2024
analogrelay
reviewed
Oct 25, 2024
RickWinter
approved these changes
Oct 31, 2024
sdk/typespec/typespec_client_core/examples/binary_data_request.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactors
FileStreamfromazure_coretotypespec_client_core, plus some trait implementations on necessary request structures to make it all work.